Issue 111668 - Getting the default text attributes in Impress Outline reliably crashes Impress
Summary: Getting the default text attributes in Impress Outline reliably crashes Impress
Status: CLOSED FIXED
Alias: None
Product: Impress
Classification: Application
Component: ui (show other issues)
Version: OOo 3.2
Hardware: Sun Solaris
: P2 Trivial (vote)
Target Milestone: OOo 3.3
Assignee: eric.savary
QA Contact: issues@graphics
URL:
Keywords: accessibility
Depends on:
Blocks:
 
Reported: 2010-05-18 02:56 UTC by joaniediggs
Modified: 2017-05-20 10:24 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description joaniediggs 2010-05-18 02:56:49 UTC 
Steps to reproduce:

1. Launch Impress (I'm using 3.3), create a new blank presentation, switch to
Outline

2. Launch Accerciser. In the tree of accessibles on the left, select the object
corresponding to the paragraph with the caret.

3. With that object highlighted, switch to Accerciser's Interface Viewer. Expand
'Text' so that the 'Include defaults' checkbox is visible

4. Check the 'Include defaults' checkbox

Results: Impress crashes 100% of the time.

(I know you guys set your own priorities. But on this one, I'm requesting
consideration as P2 for the following reason: Orca has a feature to "underline"
formats of interest in braille. If a user has this enabled -- and many of our
users do -- Orca will ask for the default attributes and thus these Orca users
will always cause Impress to crash simply by switching to the Outline.)
Comment 1 eric.savary 2010-05-18 13:17:10 UTC 
@Joanie: "our own priorities" is not completely true. You are always welcome to
P2 when it's a crash.

@AF: crash reproducible as described in DEV300m77.
Comment 2 groucho266 2010-06-10 17:12:16 UTC 
The crash takes place in SvxunoTextRangeBase.  The mpEditSource member was NULL.

Added checks in two places to avoid accessing the NULL pointer.
Comment 3 groucho266 2010-06-10 17:16:45 UTC 
@TL: I think that you are the owner of the edit engine code nowadays.  Please
review my changes in editeng/source/uno/unotext.cxx (in SetSelection() near line
353 and the constructor near line 263.)  The changes fix the crash but maybe not
the root cause.
Comment 4 groucho266 2010-06-14 12:17:00 UTC 
@es: Please verify.
Comment 5 eric.savary 2010-06-15 14:57:37 UTC 
Crash is fixed and verified.
Now a freeze comes instead: issue 112420