Issue 113897 - macros get lost on open if form control is present
Summary: macros get lost on open if form control is present
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: code (show other issues)
Version: OOO330m4
Hardware: Unknown All
: P2 Trivial (vote)
Target Milestone: OOo 3.3
Assignee: marc.neumann
QA Contact: issues@framework
URL:
Keywords: regression
Depends on:
Blocks: 111112
  Show dependency tree
 
Reported: 2010-08-15 10:20 UTC by Oliver Brinzing
Modified: 2017-05-20 10:22 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
test_macro_ok (9.29 KB, application/vnd.oasis.opendocument.spreadsheet)
2010-08-15 10:21 UTC, Oliver Brinzing 		no flags Details
test_macro_bug (9.88 KB, application/vnd.oasis.opendocument.spreadsheet)
2010-08-15 10:21 UTC, Oliver Brinzing 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Oliver Brinzing 2010-08-15 10:20:26 UTC 
steps to reproduce:

- open attached files with oo 3.2/3.2.1
  "test_macro_ok.ots" is same as "test_macro_bug.ots"
   except for the form control

- open "Tools - Macro's - Organize Macro's - OpenOffice.org Basic..."
- in both files there is a Module "Vordruck" with a Macro "Start"

- do same steps with OO330m4
- only "test_macro_ok.ots" will contain the macro "Start"
  -> regression
  btw saving "test_macro_bug.ots" will remove the basic from xml
  -> data loss

imho the problem is caused due to the form control, which is assigned
to a scripting framework action. if you want to make them work, install
"ScriptDispatch.oxt" from issue
http://www.openoffice.org/issues/show_bug.cgi?id=98990
with "--shared" option before.
Comment 1 Oliver Brinzing 2010-08-15 10:21:22 UTC 
Created attachment 71118 [details]
test_macro_ok
Comment 2 Oliver Brinzing 2010-08-15 10:21:52 UTC 
Created attachment 71119 [details]
test_macro_bug
Comment 3 Olaf Felka 2010-08-16 06:56:26 UTC 
@ ab: Please have a look.
Comment 4 ab 2010-08-16 09:45:01 UTC 
ab->mav: As discussed, please have a look.
I get an exception in basic/source/uno/namecont.cxx,
SfxLibraryContainer::loadLibrary(...) when calling
xLibrariesStor = mxStorage->openStorageElement(...)
Comment 5 Oliver Brinzing 2010-08-16 10:56:15 UTC 
just noticed: 

- open "test_macro_bug.ots" with OO330m4 via 
  "File - Templates -Edit" and the macro "Start" appears.

- open "test_macro_bug.ots" as "untitled 1" with OO 3.2
  and save as "test_macro_bug.ods". (Spreadsheet Document)
  macro "Start" now will be shown with OO330m4...
Comment 6 mikhail.voytenko 2010-08-16 15:02:31 UTC 
The bug was only triggered by the last changes in calc. The real problem is
older, it is a duplication of the library containers in the sfx that is now
described by issue 113914 and should be solved for OOo3.4.

There is an easy and safe solution for this problem before issue 113914 is
solved, so this issue should be fixed as showstopper from my point of view.
Comment 7 Oliver Brinzing 2010-08-16 15:44:14 UTC 
setting keyword regression
added to release blockers
Comment 8 mikhail.voytenko 2010-08-18 10:15:56 UTC 
Fixed in cws fwk153.
Comment 9 carsten.driesner 2010-08-19 10:47:12 UTC 
cd->of: Please verify.
Comment 10 Olaf Felka 2010-08-19 10:53:33 UTC 
I'm not the right one to test and justify such issues.
Comment 11 Olaf Felka 2010-08-19 13:42:43 UTC 
@ hde, msc: Is this something for you?
Comment 12 marc.neumann 2010-08-20 07:37:57 UTC 
I will have a look.
Comment 13 marc.neumann 2010-08-20 08:18:56 UTC 
verified in cws fwk153 . in the cws the macro is available when open the bug
template.