Created attachment 24771 [details]
Proposed patch for the enhancement

Appropriate component is framework.

CD: I have just looked through your proposed patch and from a technical point of
view it looks ok. I am a little bit concered about the massive amount of slots
used for sending a documents with different file formats as an e-mail. The PDF
feature was just a quick additional implementation, so we decided to use a new
slot. If we want to support more than pdf and the default file format, we should
use a more common approach (something like SID_MAIL_SENDDOCASFORMAT) and provide
the format as a parameter.

SfxBoolItem SendMailDocAsFormat SID_MAIL_SENDDOCASFORMAT
(SfxStringItem Recipient SID_MAIL_RECIPIENT,SfxStringItem Subject
SID_MAIL_SUBJECT,SfxStringItem MailText SID_MAIL_TEXT,SfxUInt16Item Priority
SID_MAIL_PRIORITY,SfxStringItem FilterName SID_FILTER_NAME, SfxStringItem
FilterOptions SID_FILE_FILTEROPTIONS)

The menu can use the following commands to provide the filter:
".uno:SendMailDocAsFormat?FilterName:string=<filter name1>
".uno:SendMailDocAsFormat?FilterName:string=<filter name2>

I am just working with 1.9.91-linux.  
 
When I save a file as doc or xls I cannot send it by  
"send -> document as e-mail". And no error message is coming ... 
 
With pdf and OO-format it is working, but "send as email" is 
really irritating when you are limited to certain formats.  
 
 
  
  

I can confirm this is annoying with 1.9.93. this is not an enhancement but a
serious bug, since it was working on 1.1.4 version. it should not ne neted as new

mistyped: it should not be treated as new feature.

Its not a new feature, as the bug was filed as enhancement. The patches were 
created for m79 so there are some changes that needs to be done for m92+ 
versions. "send as xls/ppt/doc" was not there in 114 too, IHMO Only pdf was 
present.

well, i remember i used that in 1.1.4 and more, I tried that in 1.1.4 before i
posted so I know it was present.

*** Issue 18432 has been marked as a duplicate of this issue. ***

*** Issue 15848 has been marked as a duplicate of this issue. ***

*** Issue 55584 has been marked as a duplicate of this issue. ***

what about a Menu Entry "Send in other formats" that will popup a dialog where
one can select the desired format.

I guess it won't be too exotic that one wishes to send the document both in
editable format as well as PDF or to send it in both odt and doc.

@jayant_madavi: Could you modify the patch so it works like cd suggested?

*** Issue 21326 has been marked as a duplicate of this issue. ***

add cd as cc:
Carsten I'm uploading a new version of the patch, it would be great to get some
feedback. Thanks

I don't think Jayant is looking after this anymore, anyway there was a bug with
the original patch ( it seems attaching an unsaved ( untitlted ) document as pdf
just doesn't work ) ). 
So, yes agreed the excessive Slot usage is a problem. I have reworked the patch
to cater for that as per your sugguestions. But, unfamiliarity with SIDs,
resource files and such leave me with more questions. So first a little about
the patch, then I'll try and outline my questions.

a) removed SID_MAIL_SENDDOCASPDF, so "Send Mail", "Send Mail as PDF attachment",
"Send Mail as MS xxxx attachment" all now use the same command. :-)
b) I didn't change the name of either the existing SLOT or the existing command,
of course if thats really an issue thats not a problem to change ( imo the
existing command with the additional filter arg is clear enough ) e.g. for calc
the commands are as follows
    + ".uno:SendMail" for attach 'this' calc doc
    + ".uno:SendMail?FilterName:string=calc_pdf_Export" attach doc as pdf
    + ".uno:SendMail?FilterName:string=MS Excel 95" attach doc as XL file
c) a good thing is now the SfxMailModel_Impl::SaveDocAsPDF method is no more,
and a fair amound of code duplication gone with it, see the patch for more info.
so to my questions, 
a) in the patch I removed a number of instances of
SID_MAIL_SENDDOCASPDF/ITEM_FILE_MAIL_SENDDOCASPDF, in svx/inc/globlmn_tmpl.hrc
these seem to defined the help-id and translations for en & de. I thought that
the translations were defined in the xml file. Maybe this is an artifact from a
previous implementation, could you clarify
b) Similarly in  sd/source/ui/app/menuids2_tmpl.src it seems there is a
redundandt Menu structure definition, again info on that would be great

I'd dearly like to get this into OO2.0, maybe its possible for 2.0.3, I'm
willing to help out to do that.

Created attachment 34428 [details]
new patch

add myself as cc

cd: Set myself as owner again.
cd->npower: Thank you for your great work. Please give me some time to verify
your changes. I think we should be able to get this into OOo 2.0.3 as it makes
life easier for many people using the "Send doc as e-Mail" feature. I add user
experience on cc. 
cd->cj,fl: What do you think about this enhancement?

cd: Started.

npower->cd thanks :-) for your quick response, might I suggest that issue 35780
be added to whatever cws this gets done in. I know this issue is closed [1], but
it mentions an rfe ( sorry I dont't know what the rfe number is, I'll try to dig
and see if I can find it if I get a chance )

[1] 
    * the issue in question is imo wrongly closed, it does however mention that
there is a ( as yet not found ) RFE associated with it. 
    * the fix is extreemly trivial ( or so it seems from a glance )
    * the present ( apparently works as specified ) behavior is imho very very
wrong.
    * if you agree with the above statements, then it makes sense to fix this at
the same time ( they are somewhat related )
Of course if I can do anything to make any of this happen quickly/easily etc.
just let me know.

I am not sure if some of UI text are localizable:
officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu
officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu
officecfg/registry/data/org/openoffice/Office/UI/DrawImpressCommands.xcu	
because it misses the de text version...

CJ -> CD: Here are my two cents.
From a users point of view I suggest to add the following UI to this feature.

- The attachment has in any case the name of the document
- Systems default e-mail client, or the e-mail client specified in Ooo options
hasto be launched automatically with the document attached.
- The File -> Send menu should be extendend by the following entries listed below

For Writer:
[position: BELOW Document as PDFAttachment…]
Document as Microsoft Word Attachment…
Dokument als Microsoft Word-Anhang…

For Calc:
[position: BELOW Document as PDFAttachment…]
Document as Microsoft Excel Attachment…
Dokument als Microsoft Excel-Anhang…

For Impress:
[position: BELOW Document as PDFAttachment…]
Document as Microsoft PowerPoint Attachment…
Dokument als Microsoft PowerPoint-Anhang…

For Draw:
[position: BELOW Document as PDFAttachment…]
Document as Microsoft PowerPoint Attachment…
Dokument als Microsoft PowerPoint-Anhang…

cd: Positive feedback from user experience. I set this issue to OOo 2.0.3 and
start to integrate it.

npower->cd
Can you tell me which cws this is worked on?

cd->npower: CWS fwk36. Work in progress as I want to fix other bugs related to
"send document as e-mail", too.

npower->cd
>CWS fwk36. Work in progress as I want to fix other bugs related to
>"send document as e-mail", too.
Thats no problem, I'm not trying to hassle you :-) I just want to track it for
my own purposes ( e.g. I can replace my patch with yours, I need to monitor the
cws so I can remove this patch from ooo-build when this cws is integrated etc...
) Anyway thanks for taking care of this :-)

cd->npower: I hope that we have a working CWS on friday. We changed your patch
to have a better abstraction from the sfx internals. The current implementation
only uses UNO API, so we would be able to move this code into a separate
service. I also fixed i35780 (we now use a temporary folder).

npower->cd I look forward to seeing the changes you made ( good opportunity for
me to learn ), brilliant to here that issue 35780 is also dealt with. Thanks again

cd: The menu item for draw must be removed as it is not able to export its
content to a MS file format. 

cd: My approach to fix this issue has a big drawback. Using a paramter to
provide the document filter or type is not useful, if someone wants to customize
this command. The customize dialog currently only works with plain
slots/commands. It doesn't support something like parameters. Therefore the
solution uses a slot/command which has a type parameter, but uses MS file format
as default. This provides maximum flexibility and the user is able to customize
this new command to a toolbar or menu bar.

cd->hi: Please verify.

cd->npower: The fix should be complete now. If want to know any details or you
need help, don't hesitate to ask me. Thanks again for your work and patch.

re-open issue and reassign to hi@openoffice.org

reassign to hi@openoffice.org

reset resolution to FIXED

>cd->npower: The fix should be complete now. If want to know any details or you
>need help, don't hesitate to ask me. Thanks again for your work and patch.
npower->cd: No! thank YOU, for handling this, unfortunately I havent't had a
chance to look at the latest and greatest version yet :-(

Verified with cws fwk36 = ok

add me to cc list

cd: Added missing spec URL.

Hi Carsten, the spec does not load for me. Better a corupt spec than a corupt
colleague, gell?

Created attachment 35555 [details]
Test case specification

Verified with 680m168 = ok